On lot of page Enter used for DELETE

[Baji Zsolt]

A very problematic situation. You change something on page Devices, Profiles (etc.) where You have Delete button, on keyboard hit Enter and it press Delete not Save! This is a very frustrating bug. Everything works fine when You use SAVE by mouse.

Branch: master a449ac37749dfdf2d269fa9458c31dbcaeea6bee

 

[hfoster]

Is it possible due to the new keyboard shortcuts?

I personally disable the keyboard_shortcuts in the default settings. They're an anti-pattern for a website, and caused no end of complaints for me.

 

[Baji Zsolt]

Hello, no, it is not shortcut. I have tracked now the request in FF Debug Toolbar. When I have pressed ENTER, Next request is called:
POST
https://******/app/devices/device_edit.php?id=930fe8db-255c-4088-845e-bfe507824f02

file_action	""
target_file	""
action	"delete"
device_mac_address	"00c0df5*****"
device_label	"1000"
device_template	"yealink/t31g"
device_lines[0][device_line_uuid]	"8996a7fd-e331-403f-aef5-ab87b390fe8f"
device_lines[0][line_number]	"1"
device_lines[0][server_address]	"*****"
device_lines[0][label]	"1000"
device_lines[0][display_name]	""
device_lines[0][user_id]	"1000"
device_lines[0][auth_id]	"1000"
device_lines[0][password]	"*********"
device_lines[0][sip_port]	"5061"
device_lines[0][sip_transport]	"tls"
device_lines[0][register_expires]	"120"
device_lines[0][shared_line]	""
device_lines[0][enabled]	"true"
device_lines_delete[0][uuid]	"8996a7fd-e331-403f-aef5-ab87b390fe8f"
device_lines[1][device_line_uuid]	"2d5d766d-fed9-4e79-b579-95e2969ddb72"
device_lines[1][line_number]	"2"
device_lines[1][server_address]	""
device_lines[1][label]	""
device_lines[1][display_name]	""
device_lines[1][user_id]	""
device_lines[1][auth_id]	""
device_lines[1][password]	""
device_lines[1][sip_port]	"5060"
device_lines[1][sip_transport]	"tcp"
device_lines[1][register_expires]	"120"
device_lines[1][shared_line]	""
device_lines[1][enabled]	"true"
device_lines_delete[1][uuid]	"2d5d766d-fed9-4e79-b579-95e2969ddb72"
device_lines[2][line_number]	""
device_lines[2][server_address]	""
device_lines[2][label]	""
device_lines[2][display_name]	""
device_lines[2][user_id]	""
device_lines[2][auth_id]	""
device_lines[2][password]	""
device_lines[2][sip_port]	"5060"
device_lines[2][sip_transport]	"tcp"
device_lines[2][register_expires]	"120"
device_lines[2][shared_line]	""
device_lines[2][enabled]	"true"
device_keys[0][device_key_uuid]	"6ed1e02f-96b3-40cc-9bc2-ea210ce3f8f0"
device_keys[0][device_key_category]	"line"
device_keys[0][device_key_id]	"5"
device_keys[0][device_key_vendor]	"yealink"
device_keys[0][device_key_type]	"16"
device_keys[0][device_key_line]	"0"
device_keys[0][device_key_value]	"1001"
device_keys[0][device_key_label]	"********"
device_keys_delete[0][uuid]	"6ed1e02f-96b3-40cc-9bc2-ea210ce3f8f0"
device_keys[1][device_key_category]	""
device_keys[1][device_key_id]	""
device_keys[1][device_key_vendor]	"yealink"
device_keys[1][device_key_type]	""
device_keys[1][device_key_line]	"0"
device_keys[1][device_key_value]	""
device_keys[1][device_key_label]	""
device_settings[0][device_setting_subcategory]	""
device_settings[0][device_setting_value]	""
device_settings[0][device_setting_enabled]	"true"
device_settings[0][device_setting_description]	""
device_user_uuid	""
device_username	""
device_password	""
device_vendor	"yealink"
device_location	""
domain_uuid	"70202a5e-717f-4790-bfbc-973e8fb27f19"
device_enabled	"true"
device_description	""
device_uuid	"930fe8db-255c-4088-845e-bfe507824f02"
e30b4845b4b452dd566f08da062fd2422692a842e7b234210f19a7a7125c39c6	"11b856c7dbfd3b6ec93dbe2b46b2d2857395b4f85216ab51bfed4089e48023b6"

 

[Baji Zsolt]

I'm not sure, I don't see submit button defined in from:

<a href="devices.php" target="_self"><button type="button" id="btn_back" alt="Back" title="Back" class="btn btn-default "><span class="fas fa-step-backward fa-fw"></span><span class="button-label hide-md-dn pad">Back</span></button></a><a href="/app/devices/cmd.php?cmd=check_sync&amp;user=@&amp;domain=&amp;agent=" target="_self" style="margin-left: 15px; "><button type="button" alt="Provision" title="Provision" class="btn btn-default "><span class="fas fa-fax fa-fw"></span><span class="button-label hide-md-dn pad">Provision</span></button></a><button type="button" id="button_files" alt="Files" title="Files" onclick="show_files()" class="btn btn-default "><span class="fas fa-download fa-fw"></span><span class="button-label hide-md-dn pad">Files</span></button><select class="formfld" style="display: none; width: auto;" name="target_file" id="target_file" onchange="download(this.value)">
....<button type="button" name="btn_copy" alt="Copy" title="Copy" onclick="modal_open('modal-copy','new_mac_address');" class="btn btn-default "><span class="fas fa-copy fa-fw"></span><span class="button-label hide-md-dn pad">Copy</span></button><button type="button" name="btn_delete" alt="Delete" title="Delete" onclick="modal_open('modal-delete','btn_delete');" class="btn btn-default "><span class="fas fa-trash fa-fw"></span><span class="button-label hide-md-dn pad">Delete</span></button><button type="button" id="btn_save" alt="Save" title="Save" onclick="submit_form();" class="btn btn-default " style="margin-left: 15px; "><span class="fas fa-bolt fa-fw"></span><span class="button-label hide-md-dn pad">Save</span></button>

I don't know what is the default in this situation. Why is in default form submit added "

action

"delete"

in post params?