Hi,
We are still working out the right order of steps after the Ringotel breach and have only tested on a few extensions, so I'd like your advice at each step. I read the current master code, so my assumptions may not match v2.2.2.
STEP 1: THE API TOKEN
1a. We rotated the Ringotel API key and entered it with the API Token button (Default Settings, mobile_apps / ringotel_api_token). Is that the only place FS PBX stores it?
1b. Is the token encrypted at rest in Default Settings?
1c. Do any queued or failed jobs in the ringotel queue keep using the old token?
STEP 2: THE WEBHOOK
2a. The webhook check compares the request's api_key with the same API token, using ===. Is the API key meant to double as the webhook secret?
2b. If the token is ever empty, would a request with no api_key pass (null === null)?
2c. Could we have a separate webhook secret, and a constant-time comparison (hash_equals)?
2d. Is there a way to switch off the webhook and the Ringotel jobs quickly during an incident?
STEP 3: SIP PASSWORDS
3a. After we reset an extension's SIP password in FS PBX, what is the correct way to send it to Ringotel? Is Deactivate then Activate the only way (it calls updateUser with the extension password)?
3b. What does Reset password in the extension's mobile app tab do? It sends only the user and org IDs to resetUserPassword. Does it change the SIP password, or only the app login?
3c. Is there, or could there be, a bulk action to push current passwords to Ringotel for a whole domain?
3d. Existing registrations stay up after a password change. Is there a way in FS PBX to force them to re-register, or should we flush them with fs_cli?
STEP 4: THE ACL
4a. Ringotel's server IPs are in our rfc1918 ACL (allow, otherwise deny). Is that there for NAT handling, or does it let calls in without SIP authentication? Which sip profile settings use it?
4b. Does Ringotel need an ACL entry at all, or can it work with credentials only?
4c. If the entry must stay, what is the safest setup? For example, only the regions we use, per-extension call limits and international blocks.
4d. How should we search the CDRs for calls that came from Ringotel's IPs since Nov 20?